Add the digest-environment dependency configuration#2036
Merged
Conversation
abderrahim
requested review from
BenjaminSchubert,
cs-shadow,
gtristan and
juergbi
as code owners
abderrahim
force-pushed
the
abderrahim/digest-environment
branch
2 times, most recently
from
ba403b8 to
4f716b7
Compare
abderrahim
commented
Jul 11, 2025
juergbi
force-pushed
the
abderrahim/digest-environment
branch
2 times, most recently
from
3ed3ac8 to
973ac1c
Compare
juergbi
force-pushed
the
abderrahim/digest-environment
branch
from
973ac1c to
bd8786f
Compare
abderrahim
commented
Aug 22, 2025
Contributor
Author
abderrahim
left a comment
abderrahim
left a comment
There was a problem hiding this comment.
A few comments but otherwise looks good.
(I can't approve on Github because I created the pull request)
tests/integration/project/elements/digest-environment/base-buildtree.bst
Show resolved
Hide resolved
juergbi
force-pushed
the
abderrahim/digest-environment
branch
3 times, most recently
from
8d54e59 to
8955e5e
Compare
abderrahim
commented
Aug 24, 2025
juergbi
force-pushed
the
abderrahim/digest-environment
branch
2 times, most recently
from
587e47e to
a071816
Compare
Elements can configure additional environment variables in `configure_sandbox()`, which will be used by `BuildElement` to support `digest-environment`. Use the complete environment for logging and `bst shell`.
This allows an element to use a secondary sandbox for manipulating artifacts that don't affect the build.
With the introduction of subsandboxes, a single overlap collector is no longer sufficient.
The subsandboxes can be used to extract a CAS digest that could be used for nested remote execution, and thus need to be available in the remote execution CAS.
juergbi
force-pushed
the
abderrahim/digest-environment
branch
from
a071816 to
97edc85
Compare
abderrahim
commented
Sep 7, 2025
Contributor
Author
abderrahim
left a comment
abderrahim
left a comment
There was a problem hiding this comment.
LGTM (with a couple nits)
This is stored only when also storing the build tree. It is used to configure the sandbox for `bst shell --use-buildtree`. This is required for elements that create subsandboxes as part of `configure_sandbox()`.
This allows setting an environment variable inside the sandbox to the CAS digest of one or more dependencies. Co-authored by: Adrien Plazas <adrien.plazas@codethink.co.uk>
juergbi
force-pushed
the
abderrahim/digest-environment
branch
from
97edc85 to
a2f076f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows setting an environment variable inside the sandbox to the CAS digest of one or more dependencies.
This us useful when communicating with the nested remote execution endpoint, but could also be used independently.
This PR replaced #1991.